Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detail-view: Hide "Show All Reviews" button when there are none #491

Merged
merged 1 commit into from
Oct 8, 2023
Merged

detail-view: Hide "Show All Reviews" button when there are none #491

merged 1 commit into from
Oct 8, 2023

Conversation

oscfdezdz
Copy link
Collaborator

@oscfdezdz oscfdezdz commented Oct 7, 2023 •
edited

image

mjakeman
mjakeman approved these changes Oct 8, 2023
View reviewed changes
Copy link
Owner

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep nice catch - looks good to me

As a random thought, I wonder if we could (eventually) use property bindings for this sort of thing. i.e. Being able to link a list model with a button's visibility within blueprint.

@mjakeman mjakeman merged commit 0b09818 into master Oct 8, 2023
1 check passed
@mjakeman mjakeman deleted the oscfdezdz/no-comments branch October 8, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjakeman mjakeman mjakeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscfdezdz @mjakeman