Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail-view: Add info bar #492

Merged
merged 1 commit into from
Nov 16, 2023
Merged

detail-view: Add info bar #492

merged 1 commit into from
Nov 16, 2023

Conversation

oscfdezdz
Copy link
Collaborator

@oscfdezdz oscfdezdz commented Oct 12, 2023

TODO:

  • Show latest version available for the installed GNOME Shell version
  • Drop supported versions (?)
  • Make it focusable for keyboard navigation and screen readers
  • Review implementation again

image

@oscfdezdz oscfdezdz force-pushed the oscfdezdz/info-bar branch 5 times, most recently from f5593ca to bf5709f Compare October 18, 2023 11:20
@oscfdezdz oscfdezdz assigned oscfdezdz and unassigned oscfdezdz Oct 18, 2023
@oscfdezdz oscfdezdz marked this pull request as ready for review October 21, 2023 10:55
@oscfdezdz
Copy link
Collaborator Author

oscfdezdz commented Oct 21, 2023

It's ready now, at least for review. I tried to make it easy to add more information in the future, since, for example, session modes are not available for now.

Also, I removed supported versions but I'm not sure if that was only in the case of using GNOME version instead of extension version.

As for layout, it's still an open question.

EDIT: I'm also keeping an eye on https://gitlab.gnome.org/Infrastructure/extensions-web/-/merge_requests/154 to make changes here if it gets merged.

@oscfdezdz
Copy link
Collaborator Author

oscfdezdz commented Oct 23, 2023

Actually, adding more elements would require changes for smaller screens. I've to figure out how to use the AdwBreakPoint of exm-window here.

@oscfdezdz oscfdezdz marked this pull request as draft October 26, 2023 20:34
@oscfdezdz oscfdezdz marked this pull request as ready for review November 4, 2023 19:27
@mjakeman
Copy link
Owner

mjakeman commented Nov 8, 2023

Really like the direction this is going in.

I think it's fine as-is if you can fix the merge conflicts, as it doesn't look as out of place with the new Homepage Extension tab.

For now let's hold off on merging. I'll tag a new release with a lot of your recent bug fixes and changes (v0.4.3) to fix the search issues people have been having. Then we can look at merging this plus some other broader changes to the design page for 0.5.

@oscfdezdz
Copy link
Collaborator Author

oscfdezdz commented Nov 9, 2023

Merge conflicts are solved!

BTW version_name is a new field, it doesn't replace the existing version field.

Copy link
Owner

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean implementation - this is awesome

I think the info-bar/info-bar-item pattern (defining properties in blueprint) is really nice. Will look to use this more across the UI when it gets a long overdue revisit.

Regarding version_name, that can be a follow up PR. Let's merge this while there are no conflicts

@mjakeman mjakeman merged commit f3e540d into master Nov 16, 2023
1 check passed
@mjakeman mjakeman deleted the oscfdezdz/info-bar branch November 16, 2023 12:07
@oscfdezdz
Copy link
Collaborator Author

Thanks! Since the rows in GTK/Libadwaita are only for vertical layouts and I didn't see another widget with a similar look and feel, a custom widget seemed the best option for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants