detail-view: Add extension icon

[oscfdezdz]

If the extension has one.

For now it is mostly a duplication of the code that manages screenshots.

[oscfdezdz]

In those without icon, would it be better to show a symbolic or not show anything at all? From what I have read of the default icon, it was one of the problems stated in the GNOME Circle review. This change could be discussed later, after the requirements are met.

[mjakeman]

Having a think about this - from a code perspective, looks good 👍

The main worry is that extension icons are very low-res. We'd probably want to avoid displaying pixellated or blurry icons, so it might be worth giving a maximum size (say 64x64) and always rendering at that resolution. I think if we do this, it'd be worth having a placeholder icon too. As per the Circle review, I imagine they'd want a symbolic.

[oscfdezdz]

Using puzzle symbolic as placeholder:

[oscfdezdz]

The main worry is that extension icons are very low-res. We'd probably want to avoid displaying pixellated or blurry icons, so it might be worth giving a maximum size (say 64x64) and always rendering at that resolution.

Setting pixel-size property to 64 should ensure that.

[mjakeman]

Alright, I'm back! Time to start reviewing 😨

Thanks for this, looking good. We can tune the exact sizing/visuals later if needed