Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detail-view: Split screenshot overlay into its own view #595

Merged
merged 1 commit into from
Mar 17, 2024
Merged

detail-view: Split screenshot overlay into its own view #595

merged 1 commit into from
Mar 17, 2024

Conversation

oscfdezdz
Copy link
Collaborator

@oscfdezdz oscfdezdz commented Mar 15, 2024 •
edited

Fixes

  • Pop the image back in from fullscreen

in #485

@oscfdezdz oscfdezdz force-pushed the screenshot-view branch 6 times, most recently from bd6417c to e98b9e1 Compare March 15, 2024 19:06
mjakeman
mjakeman approved these changes Mar 17, 2024
View reviewed changes
Copy link
Owner

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is honestly much better - great work on this

@mjakeman mjakeman merged commit 2cb3515 into master Mar 17, 2024
1 check passed
@mjakeman mjakeman deleted the screenshot-view branch March 17, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjakeman mjakeman mjakeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscfdezdz @mjakeman