desktop: Update translators comment #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value type of the Keywords key is localestring(s), so translators can translate this string: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html However, they must keep the separator semicolons as it is, so explicit that instead.
|
The reason we have keywords is because of issue #481, that's why it contains the app name which should already be covered by I'm fine with these changes, since as you mention it's translatable, but it should also mention leaving the original strings and adding the translations afterwards to address that issue. |
Mention that translators should leave the original strings
Thank you for your quick review and info. I added that comment. |
oscfdezdz
approved these changes
Mar 26, 2024
Co-authored-by: Óscar Fernández Díaz <42654671+oscfdezdz@users.noreply.github.com>
oscfdezdz
added a commit
that referenced
this pull request
Mar 31, 2024
* desktop: Update translators comment The value type of the Keywords key is localestring(s), so translators can translate this string: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html However, they must keep the separator semicolons as it is, so explicit that instead. * desktop: Update translators comment Mention that translators should leave the original strings * Apply suggested change Co-authored-by: Óscar Fernández Díaz <42654671+oscfdezdz@users.noreply.github.com> --------- Co-authored-by: Óscar Fernández Díaz <42654671+oscfdezdz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value type of the Keywords key is localestring(s), so translators can translate this string:
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
However, they must keep the separator semicolons as it is, so explicit that instead.