Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on macOS #30

Merged
merged 3 commits into from Mar 3, 2022
Merged

Fix compilation on macOS #30

merged 3 commits into from Mar 3, 2022

Conversation

mjarvis
Copy link
Owner

@mjarvis mjarvis commented Feb 24, 2022

Resolves #31

Separates Example app into iOS and macOS targets.
Updates Exhibition code to compile + run to macOS.

Unable to currently test myself as I'm using macOS 11.6, and some of the swiftui features in use are macOS 12+ only. Will see how CI does and look into updating my computer.

Separates Example app into iOS and macOS targets.
Updates Exhibition code to compile + run to macOS.

Unable to currently test myself as I'm using macOS 11.6, and some of the swiftui features in use are macOS 12+ only. Will see how CI does and look into updating my computer.
@mjarvis
Copy link
Owner Author

mjarvis commented Feb 24, 2022

Ah, well, Github actions is also macOS 11, so will need to adjust the package and SwiftUI usage to support that.

This PR can act as a starting point for that work.

Malcolm Jarvis added 2 commits March 2, 2022 16:01
# Conflicts:
#	.github/workflows/test.yml
UI is very buggy, but at least both Exhibition and the example app compile + run
Copy link
Collaborator

@IanHoar IanHoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sucks to have to bring along some of the baggage of this older version but nice to have it working on MacOS

@mjarvis mjarvis merged commit 3475cd6 into main Mar 3, 2022
@mjarvis mjarvis deleted the mjarvis/macos branch March 3, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compilation on macOS
2 participants