Incorrect code if grandparent class overrides equals(Object) / hashCode()

[chludwig-haufe]

Hi,

the plugin adds calls super.equals(obj) and super.hashCode(), respctively, if the parent class has its own implementation of these methods (and the parent class is not java.lang.Object).

However, the plugin fails to call super.equals(obj) and super.hashCode() if these were overriden in a class further up in the hierarchy. The code in https://dl.dropboxusercontent.com/u/1675887/OverridenEqualsHashCode.zip demonstrates this issue:

• Class A has two subclasses B1 and B2. B1 has a subclass C1, and B2 has a subclass C2.
• A and B1 do override equals(Object) and hashCode(); B2 does not.
• The equals(Object) and hashCode() implementations generated for C1 are correct, they call the overridden implementations, respectively.
• The code generated for C2 does not call super.equals(obj) and super.hashCode(), respectively, even though its equality does also depend on A's notion of equality.

Regards
Christoph

[mjedynak]

Fixed in v. 1.0.9

[chludwig-haufe]

Thanks for the prompt fix!

Regards,
Christoph

From: Michal Jedynak [mailto:notifications@github.com]
Sent: Tuesday, February 04, 2014 9:13 PM
To: mjedynak/EqualsHashCodeDeluxeGenerator
Cc: Ludwig, Christoph
Subject: Re: [EqualsHashCodeDeluxeGenerator] Incorrect code if grandparent class overrides equals(Object) / hashCode() (#13)

Fixed in v. 1.0.9

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-34101609.

[jruillier]

Thanks !

[vanhove]

It still generates a faulty equals method:
f (obj == null || getClass() != obj.getClass()) {

It doesn't use the instanceOf and it doesn't do super.equals() in the return statement

[mjedynak]

The 'equals' method is generated according to http://www.technofundo.com/tech/java/equalhash.html, which describes why '(obj == null || getClass() != obj.getClass())' should be used instead of 'instanceOf'.
It also calls 'super.equals()' if it was overridden in inheritance hierarchy.