Skip to content

Commit

Permalink
App history API to navigation API rename (3/n)
Browse files Browse the repository at this point in the history
See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}
NOKEYCHECK=True
GitOrigin-RevId: e65e212e00b19e814e56c697a7b67a5895916a10
  • Loading branch information
domenic authored and Copybara-Service committed Mar 16, 2022
1 parent 97a74d5 commit 4790573
Show file tree
Hide file tree
Showing 155 changed files with 812 additions and 809 deletions.
64 changes: 32 additions & 32 deletions blink/renderer/bindings/generated_in_core.gni
Original file line number Diff line number Diff line change
Expand Up @@ -87,24 +87,24 @@ generated_dictionary_sources_in_core = [
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_animation_event_init.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_animation_playback_event_init.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_animation_playback_event_init.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_current_change_event_init.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_current_change_event_init.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigate_event_init.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigate_event_init.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigate_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigate_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigation_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigation_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_reload_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_reload_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_result.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_result.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_transition.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_transition.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_transition_while_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_transition_while_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_update_current_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_update_current_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigate_event_init.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigate_event_init.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_current_entry_change_event_init.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_current_entry_change_event_init.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_navigate_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_navigate_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_reload_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_reload_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_result.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_result.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_transition_while_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_transition_while_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_transition.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_transition.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_update_current_entry_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_update_current_entry_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_assigned_nodes_options.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_assigned_nodes_options.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_base_keyframe.cc",
Expand Down Expand Up @@ -539,20 +539,6 @@ generated_interface_sources_in_core = [
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_animation_playback_event.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_animation_timeline.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_animation_timeline.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_current_change_event.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_current_change_event.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_destination.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_destination.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_entry.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_entry.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_focus_reset.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_focus_reset.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigate_event.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigate_event.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigation_type.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_app_history_navigation_type.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_attr.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_attr.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_attribution_reporting.cc",
Expand Down Expand Up @@ -1061,6 +1047,20 @@ generated_interface_sources_in_core = [
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_mutation_record.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_named_node_map.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_named_node_map.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigate_event.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigate_event.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_current_entry_change_event.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_current_entry_change_event.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_destination.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_destination.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_focus_reset.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_focus_reset.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_history_entry.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_history_entry.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_navigation_type.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation_navigation_type.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigation.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigator.cc",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigator.h",
"$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_navigator_ua_data.cc",
Expand Down
30 changes: 15 additions & 15 deletions blink/renderer/bindings/idl_in_core.gni
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,6 @@ static_idl_files_in_core = get_path_info(
"//third_party/blink/renderer/core/aom/accessible_node.idl",
"//third_party/blink/renderer/core/aom/accessible_node_list.idl",
"//third_party/blink/renderer/core/aom/computed_accessible_node.idl",
"//third_party/blink/renderer/core/app_history/app_history.idl",
"//third_party/blink/renderer/core/app_history/app_history_destination.idl",
"//third_party/blink/renderer/core/app_history/app_history_entry.idl",
"//third_party/blink/renderer/core/app_history/app_history_current_change_event.idl",
"//third_party/blink/renderer/core/app_history/app_history_current_change_event_init.idl",
"//third_party/blink/renderer/core/app_history/app_history_navigate_event.idl",
"//third_party/blink/renderer/core/app_history/app_history_navigate_event_init.idl",
"//third_party/blink/renderer/core/app_history/app_history_navigate_options.idl",
"//third_party/blink/renderer/core/app_history/app_history_navigation_options.idl",
"//third_party/blink/renderer/core/app_history/app_history_reload_options.idl",
"//third_party/blink/renderer/core/app_history/app_history_result.idl",
"//third_party/blink/renderer/core/app_history/app_history_transition.idl",
"//third_party/blink/renderer/core/app_history/app_history_transition_while_options.idl",
"//third_party/blink/renderer/core/app_history/app_history_update_current_options.idl",
"//third_party/blink/renderer/core/app_history/window_app_history.idl",
"//third_party/blink/renderer/core/clipboard/data_transfer.idl",
"//third_party/blink/renderer/core/clipboard/data_transfer_item.idl",
"//third_party/blink/renderer/core/clipboard/data_transfer_item_list.idl",
Expand Down Expand Up @@ -511,6 +496,21 @@ static_idl_files_in_core = get_path_info(
"//third_party/blink/renderer/core/mojo/test/mojo_interface_interceptor.idl",
"//third_party/blink/renderer/core/mojo/test/mojo_interface_request_event.idl",
"//third_party/blink/renderer/core/mojo/test/mojo_interface_request_event_init.idl",
"//third_party/blink/renderer/core/navigation_api/navigate_event_init.idl",
"//third_party/blink/renderer/core/navigation_api/navigate_event.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_current_entry_change_event_init.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_current_entry_change_event.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_destination.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_history_entry.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_navigate_options.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_options.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_reload_options.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_result.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_transition_while_options.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_transition.idl",
"//third_party/blink/renderer/core/navigation_api/navigation_update_current_entry_options.idl",
"//third_party/blink/renderer/core/navigation_api/navigation.idl",
"//third_party/blink/renderer/core/navigation_api/window_navigation.idl",
"//third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.idl",
"//third_party/blink/renderer/core/page/color_page_popup_controller.idl",
"//third_party/blink/renderer/core/page/page_popup_controller.idl",
Expand Down
11 changes: 6 additions & 5 deletions blink/renderer/core/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import("//third_party/blink/renderer/core/accessibility/build.gni")
import("//third_party/blink/renderer/core/animation/build.gni")
import("//third_party/blink/renderer/core/animation_frame/build.gni")
import("//third_party/blink/renderer/core/aom/build.gni")
import("//third_party/blink/renderer/core/app_history/build.gni")
import("//third_party/blink/renderer/core/clipboard/build.gni")
import("//third_party/blink/renderer/core/content_capture/build.gni")
import("//third_party/blink/renderer/core/context_features/build.gni")
Expand Down Expand Up @@ -48,6 +47,7 @@ import("//third_party/blink/renderer/core/mathml/build.gni")
import("//third_party/blink/renderer/core/messaging/build.gni")
import("//third_party/blink/renderer/core/mobile_metrics/build.gni")
import("//third_party/blink/renderer/core/mojo/build.gni")
import("//third_party/blink/renderer/core/navigation_api/build.gni")
import("//third_party/blink/renderer/core/offscreencanvas/build.gni")
import("//third_party/blink/renderer/core/origin_trials/build.gni")
import("//third_party/blink/renderer/core/page/build.gni")
Expand Down Expand Up @@ -202,7 +202,6 @@ component("core") {
sources +=
rebase_path(blink_core_sources_animation_frame, "", "animation_frame")
sources += rebase_path(blink_core_sources_aom, "", "aom")
sources += rebase_path(blink_core_sources_app_history, "", "app_history")
sources += rebase_path(blink_core_sources_clipboard, "", "clipboard")
sources +=
rebase_path(blink_core_sources_content_capture, "", "content_capture")
Expand Down Expand Up @@ -244,6 +243,8 @@ component("core") {
sources +=
rebase_path(blink_core_sources_mobile_metrics, "", "mobile_metrics")
sources += rebase_path(blink_core_sources_mojo, "", "mojo")
sources +=
rebase_path(blink_core_sources_navigation_api, "", "navigation_api")
sources +=
rebase_path(blink_core_sources_offscreencanvas, "", "offscreencanvas")
sources += rebase_path(blink_core_sources_origin_trials, "", "origin_trials")
Expand Down Expand Up @@ -489,8 +490,6 @@ source_set("testing") {

generate_event_interfaces("core_event_interfaces") {
sources = [
"app_history/app_history_current_change_event.idl",
"app_history/app_history_navigate_event.idl",
"css/font_face_set_load_event.idl",
"css/media_query_list_event.idl",
"dom/events/custom_event.idl",
Expand Down Expand Up @@ -531,6 +530,8 @@ generate_event_interfaces("core_event_interfaces") {
"html/forms/submit_event.idl",
"html/track/track_event.idl",
"mojo/test/mojo_interface_request_event.idl",
"navigation_api/navigate_event.idl",
"navigation_api/navigation_current_entry_change_event.idl",
]

output_file = "core/event_interface_names.json5"
Expand Down Expand Up @@ -1214,7 +1215,6 @@ source_set("unit_tests") {
testonly = true
sources = [
"accessibility/ax_context_test.cc",
"app_history/app_history_test.cc",
"clipboard/clipboard_utilities_test.cc",
"content_capture/content_capture_test.cc",
"css/css_revert_layer_value_test.cc",
Expand Down Expand Up @@ -1385,6 +1385,7 @@ source_set("unit_tests") {
"messaging/blink_transferable_message_mojom_traits_test.cc",
"messaging/message_port_descriptor_mojom_traits_test.cc",
"mobile_metrics/mobile_friendliness_checker_test.cc",
"navigation_api/navigation_api_test.cc",
"origin_trials/origin_trial_context_test.cc",
"page/autoscroll_controller_test.cc",
"page/chrome_client_impl_test.cc",
Expand Down
29 changes: 0 additions & 29 deletions blink/renderer/core/app_history/app_history.idl

This file was deleted.

This file was deleted.

42 changes: 0 additions & 42 deletions blink/renderer/core/app_history/app_history_current_change_event.h

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 4790573

Please sign in to comment.