Skip to content

Commit

Permalink
[Permissions Policy Wildcards] (7) Enable by default
Browse files Browse the repository at this point in the history
This inverts the VTS so we retain testing of the disabled code path.
Design doc:
w3c/webappsec-permissions-policy#482

This CL is part of a series:
(1) Add function to detect subdomain matches
(2) Use OriginWithPossibleWildcards in policy
(3) Propagate node source to allow list parser
(4) Parse wildcard subdomain matches
(5) Support wildcards in getAllowlistForFeature
(6) Add WPTs
(7) Enable by default

Bug: 1345994
Change-Id: I269c863da497b1fb352801e848e63c4733fc46f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3938165
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1056250}
NOKEYCHECK=True
GitOrigin-RevId: c5f4322f2d8199a5befd5784251353cde4bb8468
  • Loading branch information
arichiv authored and Copybara-Service committed Oct 7, 2022
1 parent 20716d5 commit 814225a
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 15 deletions.
2 changes: 1 addition & 1 deletion blink/common/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,7 @@ BASE_FEATURE(kFastPathPaintPropertyUpdates,

BASE_FEATURE(kWildcardSubdomainsInPermissionsPolicy,
"WildcardSubdomainsInPermissionsPolicy",
base::FEATURE_DISABLED_BY_DEFAULT);
base::FEATURE_ENABLED_BY_DEFAULT);

BASE_FEATURE(kDocumentEventNodePathCaching,
"DocumentEventNodePathCaching",
Expand Down
4 changes: 2 additions & 2 deletions blink/web_tests/VirtualTestSuites
Original file line number Diff line number Diff line change
Expand Up @@ -698,10 +698,10 @@
"args": ["--disable-features=PrefersReducedMotionClientHintHeader"]
},
{
"prefix": "wildcard-subdomains-in-permissions-policy",
"prefix": "disable-wildcard-subdomains-in-permissions-policy",
"platforms": ["Linux", "Mac", "Win"],
"bases": ["external/wpt/permissions-policy/"],
"args": ["--enable-features=WildcardSubdomainsInPermissionsPolicy"]
"args": ["--disable-features=WildcardSubdomainsInPermissionsPolicy"]
},
{
"prefix": "storage-access-api",
Expand Down

This file was deleted.

0 comments on commit 814225a

Please sign in to comment.