Obtain device name and cloud byte from HELLO_RESPONSE #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipediel
commented
Mar 18, 2020
Comment on lines
+69
to
+70
| return device(host, mac, devtype, name=name, cloud=cloud) | ||
| return device_class(host, mac, devtype, name=name, cloud=cloud) |
There was a problem hiding this comment.
I changed something that I don't completely understand here. Why were we using kwargs? Backwards compatibility? In that case, let me know and I will keep the previous syntax. Otherwise, I don't see why not use args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cloud byte is active on RM Mini 3 0x5f36 and RM4 devices the user will need to perform a procedure to disable the cloud. If we save this byte, the automation platforms will be able to inform the user that this procedure is necessary.
I will take the opportunity to suggest saving the device name. It comes in the same packet. This will improve user experience, as it will be easier to identify devices after a discovery.