Add ability to RF scan a specific frequency #613

DarkStarSword · 2021-08-15T02:11:05Z

This adds an optional parameter to find_rf_packet(), along with a
corresponding --rflearn parameter (defaulting to 433.92) to
broadlink_cli that specifies the frequency to tune to, rather than
requiring the frequency be found via sweeping. This is almost mandatory
for certain types of remotes that do not repeat their signals while the
button is held, and saves significant time when the frequency is known
in advance or when many buttons are to be captured in a row.

Fixes #459

This adds an optional parameter to find_rf_packet(), along with a corresponding --rflearn parameter (defaulting to 433.92) to broadlink_cli that specifies the frequency to tune to, rather than requiring the frequency be found via sweeping. This is almost mandatory for certain types of remotes that do not repeat their signals while the button is held, and saves significant time when the frequency is known in advance or when many buttons are to be captured in a row. Additionally: - A get_frequency() API is added to return the current frequency the device is tuned to. - A check_frequency_ex() API is added to perform functions of both check_frequency() and get_frequency() in a single call. - broadlink_cli --rfscanlearn will now report the current frequency at 1 second intervals during sweeping, and will report the frequency it finally locks on to.

DarkStarSword · 2021-08-15T02:21:25Z

Just amended the commit to fix a typo in the commit message specifying the wrong default frequency. Code is unchanged.

valleedelisle · 2021-08-31T04:02:47Z

Just tested this PR because who needs to scan the whole spectrum right? And it just worked. Nice job and thanks.

rinie · 2021-09-04T09:32:44Z

On
python broadlink_cli --type 0x272a --host ... --mac ... --rflearn 433.92

I get Device tuned to 0.0MHz
Is that correct?

And
--rfscanlearn
Learning RF Frequency, press and hold the button to learn...
Sweeping 0.0MHz...
Sweeping 0.0MHz...
Sweeping 0.0MHz...
Found RF Frequency 0.0MHz - 1 of 2!
You can now let go of the button
Press enter to continue...
To complete learning, single press the button you want to learn
Found RF Frequency - 2 of 2!

hamwong · 2021-09-06T09:32:51Z

I am using RM pro, type ID: 0x2712, does python-broadlink support RF on this model? I found LED never turn red when I start learnRF and when I use app e-broadlink, led turn red immediately after I press learn

DanielBaulig · 2021-11-04T21:07:18Z

Can we get this merged? Anything that is still blocking this?

As outlined this is super useful for remotes that don't repeat their code when holding the button. It's virtually impossible to read codes from those remotes using python-broadlink without this change.

felipediel · 2021-11-18T18:58:29Z

Hi. Much better, thanks a lot!

I just came to say that I have not forgotten this PR, it will be included as soon as I find time to give it some treatment and prepare an update for Home Assistant 👍

ScottESanDiego · 2021-12-26T23:43:39Z

Currently HA is a bit broken for learning, at least for remotes like @DarkStarSword mentioned that don't repeat the signal. I can't find a way to work around it.

felipediel · 2022-03-21T01:15:10Z

Hi @DarkStarSword. I made some changes. My remote works a bit different so I can't test. Still works for you?

romelec · 2022-06-19T21:16:37Z

I'm not @DarkStarSword but successfully tested it with an A-OK remote for a roller shutter.
It does not repeats the signal so you need to push the button at least 10 times to have a chance to detect the frequency that is reported between 433.88 and 433.92, this is much better/faster with this fix.

jkor03 · 2022-10-21T07:39:20Z

@felipediel are there still plans to add this functionality? After doing a few hours of research online, it seems like remotes with the ~433 frequency won't work until something like this is implemented. I think this frequency is especially common for ceiling fan remotes (at least that's my use case). Appreciate any insight you can provide!

ahaverty · 2022-11-15T01:52:20Z

Anything I can do to help here?
Context: I'm trying to learn a tonne of rollerhouse rf commands, to combat their rolling codes, but the sweep limitation is making it a very long manual process.

ahaverty · 2022-11-15T10:33:31Z

I've tested this PR via the cli, and it's working well for my RM4Pro,
and can confirm your changes look good too @felipediel ✅

For anyone else looking to quickstart on the PR:
Install broadlink from DarkStarSword dev branch
pip3 install git+https://github.com/DarkStarSword/python-broadlink.git@dev

Checkout the branch or download the cli file
git clone https://github.com/DarkStarSword/python-broadlink
git checkout dev
cd python-broadlink/cli

Get your broadlink devices details for the --device flag with:
python3 broadlink_discovery

Run a specific frequency learn with the above device details, and your frequency:
python3 broadlink_cli --device "0x649b 192.168.01.22 ec0bae3dea8d" --frequency 433.92 --rflearn

I'm rusty on my python/pip, so apologies if this is a roundabout way of testing the PR, but it seems to work for me on mac.

felipediel · 2022-11-20T20:13:38Z

Thank you! I'll merge as soon as I have time to create a PR in Home Assistant.

abreups · 2023-03-08T17:37:12Z

I've tested this PR via the cli, and it's working well for my RM4Pro, and can confirm your changes look good too @felipediel ✅

For anyone else looking to quickstart on the PR: Install broadlink from DarkStarSword dev branch pip3 install git+https://github.com/DarkStarSword/python-broadlink.git@dev

Checkout the branch or download the cli file git clone https://github.com/DarkStarSword/python-broadlink git checkout dev cd python-broadlink/cli

Get your broadlink devices details for the --device flag with: python3 broadlink_discovery

Run a specific frequency learn with the above device details, and your frequency: python3 broadlink_cli --device "0x649b 192.168.01.22 ec0bae3dea8d" --frequency 433.92 --rflearn

I'm rusty on my python/pip, so apologies if this is a roundabout way of testing the PR, but it seems to work for me on mac.

I tried the steps above but command complains that arguments --frequency and --rflearn are unrecognized. dev branch, yes. What am I missing?

ahaverty · 2023-03-12T14:05:27Z

I tried the steps above but command complains that arguments --frequency and --rflearn are unrecognized. dev branch, yes. What am I missing?

Are you sure you're trying the correct repo's dev branch?

abreups · 2023-03-12T18:28:24Z

You are right. I was actually using the wrong repo. Fixed.
Now when I issue the command:
./broadlink_cli --device "0x520b 192.168.68.123 ec0baea07173" --frequency 433.92 --rflearn
I immeadiately get the following message in response:

Press the button you want to learn, a short press...
Traceback (most recent call last):
  File "/home/paulo/broadlink_docker/python-broadlink/cli/./broadlink_cli", line 225, in <module>
    dev.find_rf_packet(frequency)
AttributeError: 'Device' object has no attribute 'find_rf_packet'

sthales · 2023-04-14T15:58:10Z

I've tested this PR via the cli, and it's working well for my RM4Pro, and can confirm your changes look good too @felipediel ✅

For anyone else looking to quickstart on the PR: Install broadlink from DarkStarSword dev branch pip3 install git+https://github.com/DarkStarSword/python-broadlink.git@dev

Checkout the branch or download the cli file git clone https://github.com/DarkStarSword/python-broadlink git checkout dev cd python-broadlink/cli

Get your broadlink devices details for the --device flag with: python3 broadlink_discovery

Run a specific frequency learn with the above device details, and your frequency: python3 broadlink_cli --device "0x649b 192.168.01.22 ec0bae3dea8d" --frequency 433.92 --rflearn

I'm rusty on my python/pip, so apologies if this is a roundabout way of testing the PR, but it seems to work for me on mac.

Amazing. Thank you!!

abreups · 2023-06-28T18:20:22Z

You are right. I was actually using the wrong repo. Fixed. Now when I issue the command: ./broadlink_cli --device "0x520b 192.168.68.123 ec0baea07173" --frequency 433.92 --rflearn I immeadiately get the following message in response:
Press the button you want to learn, a short press...
Traceback (most recent call last):
  File "/home/paulo/broadlink_docker/python-broadlink/cli/./broadlink_cli", line 225, in <module>
    dev.find_rf_packet(frequency)
AttributeError: 'Device' object has no attribute 'find_rf_packet'

I still get the same error. Not working.

krozgrov · 2023-07-02T03:52:21Z

I'm seeing the same error Press the button you want to learn, a short press...
Traceback (most recent call last):
File "/Users/krozgrov/Desktop/broadlink_cli.py", line 225, in
dev.find_rf_packet(frequency)
AttributeError: 'Device' object has no attribute 'find_rf_packet'

clockbrain · 2023-11-23T12:13:38Z

AttributeError: 'Device' object has no attribute 'find_rf_packet'

Sounds to me like you either didn't update broadlink/remote.py or are invoking an unpatched version. The patched version implements the frequency parameter.

In my case I manually applied the changes to broadlink_cli in my home directory and the changes to remote.py in .local/lib/python3.9/site-packages/broadlink

Works great for me.

LordIvanhoe · 2023-12-29T21:32:35Z

I'm seeing the same error Press the button you want to learn, a short press... Traceback (most recent call last): File "/Users/krozgrov/Desktop/broadlink_cli.py", line 225, in dev.find_rf_packet(frequency) AttributeError: 'Device' object has no attribute 'find_rf_packet'

I had the same problem, eventually i figured out that my RM4 Pro is newer model than those in init.py, so i just added mine and it worked. Check the ID of your RM against those listed in _init.py.

This was what i added:
0x520B: ("RM4 pro", "Broadlink")

brentleeper · 2024-02-22T18:18:11Z

Hello. Please merge this PR into the main branch. This feature works and otherwise does not change any existing functionality (the change is backwards compatible). If you do not implement this change I will fork this repo and actually maintain it.

LordIvanhoe · 2024-02-22T18:57:10Z

Hello. Please merge this PR into the main branch. This feature works and otherwise does not change any existing functionality (the change is backwards compatible). If you do not implement this change I will fork this repo and actually maintain it.

if its any help , i've already forked this and merged it, also added some new devices.. Feel free to start from there.

Here is my fork

brentleeper · 2024-02-22T19:02:35Z

Hello. Please merge this PR into the main branch. This feature works and otherwise does not change any existing functionality (the change is backwards compatible). If you do not implement this change I will fork this repo and actually maintain it.

if its any help , i've already forked this and merged it, also added some new devices.. Feel free to start from there.

Here is my fork

Awesome! Do you have this in PyPi?

LordIvanhoe · 2024-02-22T19:05:48Z

Hello. Please merge this PR into the main branch. This feature works and otherwise does not change any existing functionality (the change is backwards compatible). If you do not implement this change I will fork this repo and actually maintain it.

if its any help , i've already forked this and merged it, also added some new devices.. Feel free to start from there.
Here is my fork

Awesome! Do you have this in PyPi?

Sorry, no, i just needed a quick fix to be able to capture couple of RF remotes for my homeassistant, didnt bother any further :) But it works perfectly, no idea why this was abandoned...

brentleeper · 2024-02-22T20:38:25Z

Ok no worries. Curious if you want to make me a contributor on your repo or if I should make my own?

LordIvanhoe · 2024-02-22T20:53:56Z

Ok no worries. Curious if you want to make me a contributor on your repo or if I should make my own?

Sure thing, i've added you just now.

brentleeper · 2024-02-23T17:51:44Z

Thanks, I'll try to contribute there soon. I plan on adding a more advanced interface for creating custom devices, which are cached and available for use later and can also be edited later.

tablatronix · 2024-03-30T02:33:19Z

What is the hold up here? More testing needed?

I need to bring this into
https://github.com/t0mer/broadlinkmanager-docker
and
https://github.com/kiwi-cam/homebridge-broadlink-rm

Anyone fork these yet with this? all my remotes are 433.92 and none learn with the rm40 pro unless I set freq with the app first, maybe Ill just have it not actually sweep...

brentleeper · 2024-03-30T05:05:23Z

What is the hold up here? More testing needed?

I need to bring this into

https://github.com/t0mer/broadlinkmanager-docker

and

https://github.com/kiwi-cam/homebridge-broadlink-rm

Anyone fork these yet with this? all my remotes are 433.92 and none learn with the rm40 pro unless I set freq with the app first, maybe Ill just have it not actually sweep...

See here: https://github.com/brentleeper/python-broadlink

felipediel · 2024-04-09T18:40:49Z

Thanks @DarkStarSword! 🎉

felipediel · 2024-04-18T23:05:29Z

Ok guys, now to implement this in Home Assistant we need to create a new service to sweep the frequency separately, and this involves discussing with the core team why these changes are important. If anyone can join the discussion and share the experience with the current interface, explaining why it is problematic I would appreciate that: home-assistant/architecture#1076

DarkStarSword mentioned this pull request Aug 15, 2021

Ability to learn RF codes by providing frequency and not sweeping frequency #539

Closed

DarkStarSword force-pushed the dev branch from c03ca83 to 168b901 Compare August 15, 2021 02:17

felipediel added 2 commits March 20, 2022 21:33

Clean up remote.py

b83826e

Clean up broadlink_cli

274b317

felipediel added feature breaking-change labels Mar 21, 2022

felipediel added 2 commits March 20, 2022 21:50

Update conditional

b90c668

Fix message

81b9661

felipediel mentioned this pull request Mar 21, 2022

RF Code learning process failed at "second button press" #643

Closed

sidlauskas mentioned this pull request Sep 15, 2022

Broadlink integration not detecting a particular remote home-assistant/core#63578

Open

Chanete mentioned this pull request Feb 8, 2023

315Mhz RF learning #748

Closed

sthales approved these changes Apr 14, 2023

View reviewed changes

tilleul mentioned this pull request Aug 18, 2023

Entering learn mode with fixed frequency ThomasTavernier/node-broadlink#7

Open

romelec mentioned this pull request Dec 24, 2023

Learning RF doesn't work, IR does #739

Closed

This was referenced Jan 4, 2024

RM4 Pro Learn Feature Doesn't Work -- Scan Feature Produces inconsistent results. With Workaround. kiwi-cam/homebridge-broadlink-rm#611

Closed

Add frequency support for RM 4 pro learn kiwi-cam/homebridge-broadlink-rm#676

Open

felipediel merged commit 634370d into mjg59:dev Apr 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to RF scan a specific frequency #613

Add ability to RF scan a specific frequency #613

DarkStarSword commented Aug 15, 2021 •

edited by felipediel

Loading

DarkStarSword commented Aug 15, 2021

valleedelisle commented Aug 31, 2021

rinie commented Sep 4, 2021 •

edited

Loading

hamwong commented Sep 6, 2021

DanielBaulig commented Nov 4, 2021

felipediel commented Nov 18, 2021

ScottESanDiego commented Dec 26, 2021

felipediel commented Mar 21, 2022 •

edited

Loading

romelec commented Jun 19, 2022

jkor03 commented Oct 21, 2022

ahaverty commented Nov 15, 2022

ahaverty commented Nov 15, 2022

felipediel commented Nov 20, 2022

abreups commented Mar 8, 2023

ahaverty commented Mar 12, 2023

abreups commented Mar 12, 2023

sthales commented Apr 14, 2023

abreups commented Jun 28, 2023

krozgrov commented Jul 2, 2023 •

edited

Loading

clockbrain commented Nov 23, 2023

LordIvanhoe commented Dec 29, 2023

brentleeper commented Feb 22, 2024

LordIvanhoe commented Feb 22, 2024

brentleeper commented Feb 22, 2024

LordIvanhoe commented Feb 22, 2024

brentleeper commented Feb 22, 2024

LordIvanhoe commented Feb 22, 2024

brentleeper commented Feb 23, 2024

tablatronix commented Mar 30, 2024 •

edited

Loading

brentleeper commented Mar 30, 2024

felipediel commented Apr 9, 2024

felipediel commented Apr 18, 2024

Add ability to RF scan a specific frequency #613

Add ability to RF scan a specific frequency #613

Conversation

DarkStarSword commented Aug 15, 2021 • edited by felipediel Loading

DarkStarSword commented Aug 15, 2021

valleedelisle commented Aug 31, 2021

rinie commented Sep 4, 2021 • edited Loading

hamwong commented Sep 6, 2021

DanielBaulig commented Nov 4, 2021

felipediel commented Nov 18, 2021

ScottESanDiego commented Dec 26, 2021

felipediel commented Mar 21, 2022 • edited Loading

romelec commented Jun 19, 2022

jkor03 commented Oct 21, 2022

ahaverty commented Nov 15, 2022

ahaverty commented Nov 15, 2022

felipediel commented Nov 20, 2022

abreups commented Mar 8, 2023

ahaverty commented Mar 12, 2023

abreups commented Mar 12, 2023

sthales commented Apr 14, 2023

abreups commented Jun 28, 2023

krozgrov commented Jul 2, 2023 • edited Loading

clockbrain commented Nov 23, 2023

LordIvanhoe commented Dec 29, 2023

brentleeper commented Feb 22, 2024

LordIvanhoe commented Feb 22, 2024

brentleeper commented Feb 22, 2024

LordIvanhoe commented Feb 22, 2024

brentleeper commented Feb 22, 2024

LordIvanhoe commented Feb 22, 2024

brentleeper commented Feb 23, 2024

tablatronix commented Mar 30, 2024 • edited Loading

brentleeper commented Mar 30, 2024

felipediel commented Apr 9, 2024

felipediel commented Apr 18, 2024

DarkStarSword commented Aug 15, 2021 •

edited by felipediel

Loading

rinie commented Sep 4, 2021 •

edited

Loading

felipediel commented Mar 21, 2022 •

edited

Loading

krozgrov commented Jul 2, 2023 •

edited

Loading

tablatronix commented Mar 30, 2024 •

edited

Loading