Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Broadlink MP1 with power meter #631

Merged
merged 1 commit into from Oct 18, 2021

Conversation

felipediel
Copy link
Collaborator

@felipediel felipediel commented Oct 18, 2021

Breaking change

Change MP1-1K4S 0x4EF7's class to mp1s.

Context

Some MP1 devices have power meter. We are not supporting this sensor, currently.

Proposed change

Create mp1s class, a subclass of mp1 with get_energy() method. Refer devices to this class, when applicable.

Credits

From: #615. Thanks @vaughan-zeng!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant