Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Luceco/BG Electrical Smart Bulb (0x606d) #766

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2023

Context

The Luceco Smart Bulbs https://www.bg-home.uk/a60-globe appear to be white labelled Broadlink bulbs. Adding the ID makes them recognisable and controllable from this library.

The product's catalogue numbers: SLA22RGB9W81 or SLA27RGB9W81, are printed on the side of the device along with the Luceco brand. The bulbs are normally controlled by the BG-Home app and need to be removed from the app to be unlocked.

Proposed change

Add product ID for compatible bulb.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Adding the ID to the LB1 supported types gives access to this device. The following works as expected:

import broadlink
broadlink.discover()
device = broadlink.hello('192.168.0.56')
device.auth()
device.get_state()

device.set_state(pwr=0)
device.set_state(pwr=1)
device.set_state(bulb_colormode=0, red=255, green=0, blue=0, brightness=255)
device.set_state(bulb_colormode=1,brightness=255, colortemp=2700)
device.set_state(bulb_colormode=1,brightness=255, colortemp=6500)

No updates to documentation, this appears to be just another white label ID rather than a new device.

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@ghost ghost marked this pull request as draft July 14, 2023 09:39
@ghost ghost changed the base branch from master to new_product_ids July 14, 2023 09:40
@ghost ghost marked this pull request as ready for review July 14, 2023 09:46
@ghost
Copy link
Author

ghost commented Aug 21, 2023

Merging github accounts and moving repositories: webturneruk -> webturner.

@webturner
Copy link

I've deleted a duplicate account, please contact me if necessary regarding this PR.

@felipediel felipediel merged commit 649e2c9 into mjg59:new_product_ids Apr 10, 2024
@felipediel
Copy link
Collaborator

Awesome, thanks @webturner!

felipediel added a commit that referenced this pull request Apr 17, 2024
* Add support for Broadlink SP4M-JP (0x756B) (#782)

* Add support for Luceco/BG Electrical A60 bulb (0x606D) (#766)

* Add support for Luceco EFCF60WSMT (0xA6EF) (#787)

* Add support for Broadlink WS4 (#792)

* Add support for Broadlink SP4D-US (0xA6F4) (#793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lb1 product ID 0x606d to support BG Electrical A60 bulbs
2 participants