Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust toolchain #50

Closed
VuiMuich opened this issue Nov 6, 2021 · 4 comments · Fixed by #51
Closed

Rust toolchain #50

VuiMuich opened this issue Nov 6, 2021 · 4 comments · Fixed by #51

Comments

@VuiMuich
Copy link
Contributor

VuiMuich commented Nov 6, 2021

Is there a specific reason, why the rust toolchain is fixed to 1.50.0?
It compiles well with 1.56.1
@psibi
Copy link
Collaborator

psibi commented Nov 7, 2021

No specific reasons, I would be happy to accept a PR accepting a bump.

@VuiMuich
Copy link
Contributor Author

VuiMuich commented Nov 7, 2021

Why not simply remove the override and use whatever the default toolchain cargo is using?

@psibi
Copy link
Collaborator

psibi commented Nov 7, 2021

This is mostly to ensure reproducibility for ease of development. Having a combination of toolchain file and shell.nix ensures to me the last known version of compiler that I knew it worked with.

Also, the CI jobs are run against that compiler. That being said, I belive for the consumers of the above two crates (cnx and cnx-contrib), it doesn't matter as they aren't tied to a single rust version

@psibi psibi closed this as completed in #51 Nov 7, 2021
@VuiMuich
Copy link
Contributor Author

VuiMuich commented Nov 7, 2021

I see..

@VuiMuich VuiMuich mentioned this issue Nov 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bounce rust-toolchain to 1.56.1 VuiMuich/cnx
2 participants
@psibi @VuiMuich