Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webmail top-posting #83

Closed
mattfbacon opened this issue Oct 13, 2023 · 8 comments
Closed

Webmail top-posting #83

mattfbacon opened this issue Oct 13, 2023 · 8 comments

Comments

@mattfbacon
Copy link
Contributor

Ignoring all the quasi-religious arguments about top- vs bottom-posting, I'd like an option in the webmail for top-posting.

@mjl-
Copy link
Owner

mjl- commented Oct 13, 2023 via email

@mattfbacon
Copy link
Contributor Author

mattfbacon commented Oct 13, 2023 via email

@mattfbacon
Copy link
Contributor Author

In that case, we may also need to have the "On Friday, 1 Jan, 11:37, John Doe wrote:" thing.

@mjl-
Copy link
Owner

mjl- commented Oct 13, 2023 via email

@mattfbacon
Copy link
Contributor Author

lets users specify it in their language.

Definitely. I'd love if this could be fully customizable with format specifiers for the time, the username and email of the sender, etc.

mox webmail doesn't have a way to store settings on the server yet.

Yeah, I noticed this. It would add complexity, I guess, but it will probably be useful in the future because some things are kind of imitating configuration currently, like the threads toggle. If that could be an actual config option that persists between sessions, it would probably improve UX.

but the top vs bottom posting can be done without setting. i'll get to that in a few hours. i'll also try implementing missing utf-8 attachment filenames.

Thanks. I looked into doing this myself for both but I'm not familiar with the structure of the code. I'll definitely read your commits to learn more about it.

mjl- added a commit that referenced this issue Oct 13, 2023
…keep bottom-quoting with text selected

top-posting causes "On $datetime, $sender wrote:" above the quoted text to be
added (unless there was no Date header or valid address in a From header).

in the near future we should create settings, and add a setting for adding the
"on ... wrote"-line, ideally including a template.

for issue #83 by mattfbacon, thanks!
@mattfbacon
Copy link
Contributor Author

OK, thanks for that commit. It was simpler than I thought 🙂

@mjl-
Copy link
Owner

mjl- commented Oct 13, 2023

yeah, this was relatively easy to bolt on. the ui code doesn't have tests (so it sometimes feels like hacking in functionality, though ui tests are hard to make useful and non-brittle). at least typescripts helps with maintainability. but it's indeed somewhat surprising how easy some changes/features are to implement. (:

@mattfbacon
Copy link
Contributor Author

mattfbacon commented Oct 24, 2023

Closing this because the initial issue is resolved and server-side config is a separate thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants