-
Notifications
You must be signed in to change notification settings - Fork 14
Get RN 0.39 working #84
base: master
Are you sure you want to change the base?
Conversation
(fl/exists? cljs-file)) | ||
(new-hard-link map-file target-map) | ||
(new-hard-link cljs-file target-cljs)))) | ||
(u/dbug "Time to copy and rewrite js files to %s: %s ms\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a debug tag so that you can measure how long the copying and replacement takes
@vikeri is this approach still worth looking into? Or have you moved on to something else? |
Ah. I hope that development using boot will continue. Whenever I pick up Leiningen, I run into opaque errors and caching problems Can you outline some of the work that needs to be done? |
@theronic Unfortunately I've also transitioned to using figwheel because of faster compilation speed and better REPL + reload experience. |
@theronic, briefly: Re-natal has the better approach. It serves, via RN packager, only a small stub, including only pointers JS deps and the figwheel bridge. All the rest is done via Figwheel. No cljs code AFAIK is transferred via the RN packager in re-natal. The big advantage is that everything works just like other CLJS repls: you reduce the surface of potential problems. Boot has its own equivalents to Figwheel. The approach I'd take, if I were to rewrite BRN, would be to build on these. It would certainly be nice to have a mature Boot-based CLJSRN solution. However, there's also value in focussing development on re-natal, which is a lot more mature. I've since come to the conclusion that it's better not to divide the (already small) community. Another thing to try would be to look at the specific shortcomings of re-natal and to see where it could be improved upon. Caching is one, but you'll need to deal with caching in some way anyway. And Boot is not as fast precisely because it caches less so there'a another trade-off here. If you do take a look at bringing BRN up to speed, feel free to ask specific questions, I'll do my best to answer. |
I very crudely rewrote the
goog.require
in all the js-files torequire
and changed the output folder tocljs_output
instead. Not very pretty but I sorted out the performance hit I initially got so now it shouldn't be too bad.Fixes #78