Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why autocompletion would be amazing ? #4

Closed
arthurkatz opened this issue Jul 29, 2016 · 6 comments
Closed

Why autocompletion would be amazing ? #4

arthurkatz opened this issue Jul 29, 2016 · 6 comments

Comments

@arthurkatz
Copy link

Hello all,

I think adding an autocompletion feature could be really cool. By autocompletion, I mean this atom package could suggest attributes for every components with or without default value.
We would code even faster our emails ! Amazing right ?

Is this feature on your roadmap ?
If no, who is willing to help me on this ?

@ngarnier
Copy link
Member

ngarnier commented Sep 8, 2016

Hey @arthurkatz,

I like the idea! So to make sure I understand correctly, when using mj-text for example, the tags generated would have all the attributes that are possible to use with it with default values and you would just have to replace them?

@arthurkatz
Copy link
Author

Hey @ngarnier,
I already did that for myself, I can push it for every one if you want.
Actually if I type "text-", hit tab then it will expand to :
<mj-text color="#000000" font-family="Ubuntu, Helvetica, Arial, sans-serif" font-size="13px" font-style="" font-weight="" line-height="22px" text-decoration="" text-transform="" align="left" container-background-color="" padding="10px 25px"></mj-text>

But what I was thinking about is you type "text" then expand hitting tab, you go inside the bracket hit something like "ctrl+space" and a dropdown would appear with all the attributes availables.

@ngarnier
Copy link
Member

ngarnier commented Sep 8, 2016

Thanks, I think the 2nd option is more suitable because expanding all the attributes with default values will be a problem for people using mj-attributes (mj-all, mj-class...) as it will override what they specified.

@arthurkatz
Copy link
Author

Didn't thought about that !
I'll start working on the second option and keep you updated ;)

@barrars
Copy link

barrars commented Jan 4, 2017

Would something like atom/autocomplete-html work?

I love the functionality.

Also, getting greedy here but is it be possible to have a beautify button like in the online MJML editor.

@ngarnier
Copy link
Member

ngarnier commented Mar 7, 2018

I'm closing as this issue has been open for a long time, but feel free to submit a PR, it would be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants