Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title attribute for mj-social-element #1447

Closed
fac42 opened this issue Dec 5, 2018 · 3 comments
Closed

Add title attribute for mj-social-element #1447

fac42 opened this issue Dec 5, 2018 · 3 comments

Comments

@fac42
Copy link

fac42 commented Dec 5, 2018

Is your feature request related to a problem? Please describe.
Currently I have to open the compiled HTML and manually add title attributes to social icons.

Describe the solution you'd like
If this attribute could be added to the next version of MJML that would be great 👍.

Describe alternatives you've considered
Currently only a manually adding the title attribute is possible.

Additional context
N/A

@fac42
Copy link
Author

fac42 commented Dec 5, 2018

Just noticed that PR #1446 will fix this issue, please close this issue if the PR is accepted!

@kmcb777
Copy link
Collaborator

kmcb777 commented Dec 5, 2018

Hi @fac42 yes i remembered you asked for this on slack, and there was no reason not to allow it, now i have an issue number to put on that pr 👍

@iRyusa iRyusa closed this as completed in c8ed392 Jan 3, 2019
@kmcb777
Copy link
Collaborator

kmcb777 commented Jan 3, 2019

Hi @fac42 , this feature has been included in the new 4.3 release, feel free to try it out !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants