Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<!-- ... --> HTML Comments break the code inside an Ending Tag #153

Closed
janus-reith opened this issue Mar 24, 2016 · 4 comments
Closed

<!-- ... --> HTML Comments break the code inside an Ending Tag #153

janus-reith opened this issue Mar 24, 2016 · 4 comments

Comments

@janus-reith
Copy link

I used to comment my mjml code with tags.
Since 1.3 it seems like they get parsed somehow,
in some parts they appear as text, in some they just break the funcionality of the section after the comment.

I tried CSS comments, they also don't work.
If HTML Comments was just a thing that worked unintentionally,
you can see this as a feature request.

@iRyusa
Copy link
Member

iRyusa commented Mar 24, 2016

Hi @janus-reith

Looks like to work for me on 1.3.3 can you give me your MJML ?

@janus-reith
Copy link
Author

Hi iRyusa,

This is the code that worked before the update.
(In this code you can also see how the image width is ignored.)

code.txt

Edit: I have to correct myself:
The comments are not around sections, but instead there is one inside mj-raw,
and some inside mj-texts.

@iRyusa iRyusa changed the title <!-- ... --> HTML Comments break the code since 1.3 <!-- ... --> HTML Comments break the code inside an Ending Tag Mar 24, 2016
@iRyusa
Copy link
Member

iRyusa commented Mar 24, 2016

Updating the issue title, this might be an issue with htmlparser

@mattpirelli
Copy link

I second this issue. I've updated just yesterday to 1.3.3 and can confirm that HTML comments inside <mj-text> break the rendering. Well, it fails spectacularly 🎉

Strangely enough, HTML comments inside other components (namely, <mj-button>) don't seem to interfere with the rendering.

@iRyusa iRyusa added this to the 2.0 milestone Apr 12, 2016
@loeck loeck closed this as completed in 1fda474 Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants