Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Accessibility using Email Markup Consortium Recommendations #2725

Closed
garrettjohnson opened this issue Aug 15, 2023 · 1 comment · Fixed by #2738
Closed

Improve Accessibility using Email Markup Consortium Recommendations #2725

garrettjohnson opened this issue Aug 15, 2023 · 1 comment · Fixed by #2738

Comments

@garrettjohnson
Copy link
Contributor

garrettjohnson commented Aug 15, 2023

Is your feature request related to a problem? Please describe.
The email markup consortium has created an accessibility report and some of the top 10 issues are present in MJML, and could be fixed relatively easily.

Describe the solution you'd like

  • Fix issue 1 - Content inside the body should be wrapped in a lang attribute.
    • Can be addressed by duplicating the langAttribute tag onto the body and updating the lang default to und as recommended.
  • Fix issue 3 - Content inside the body should be wrapped in a dir attribute
    • Can also be addressed by cloning the dirAttribute tag and updating the dir default to auto as recommended
  • Fix issue 7 - Images must have alternate text
    • Set the default alt text to a blank string, using defaultAttributes, so that mjml-image always renders correctly. This default could also be implemented on mjml-social-element, and mj-carousel-image.

I'm happy to submit a PR. Thanks for a great tool.

@iRyusa
Copy link
Member

iRyusa commented Aug 23, 2023

Sorry for the late reply but a big yes for a PR about those change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants