Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI linter says "Attribute padding-bottom is illegal" on mj-link, which is incorrect. #424

Closed
quinncomendant opened this issue Oct 21, 2016 · 2 comments
Milestone

Comments

@quinncomendant
Copy link

quinncomendant commented Oct 21, 2016

I have this bit of code:

<mj-section>
  <mj-column>
    <mj-inline-links base-url="">
      <mj-link padding-bottom="0" href="http://odysseyteams.com/">odysseyteams.com</mj-link>
      <mj-link padding-bottom="0" href="mailto:learn@odysseyteams.com">learn@odysseyteams.com</mj-link>
      <mj-link padding-bottom="0" href="tel:+18003421650">800-342-1650</mj-link>
    </mj-inline-links>
  </mj-column>
</mj-section>

The mjml cli shows this warning:

Line 82 (mj-link) — Attribute padding-bottom is illegal

However, according to the docs, padding-bottom is a valid attribute on mj-link.

It does transpile successfully, so I'm just ignoring the warning for now.

@ngarnier
Copy link
Member

Thanks for reporting this issue @quinncomendant, we'll fix this!

@ngarnier ngarnier added this to the 3.1.0 milestone Nov 10, 2016
@ngarnier
Copy link
Member

ngarnier commented Dec 6, 2016

This should be fixed now that 3.1.0 is released, thanks!

@ngarnier ngarnier closed this as completed Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
MJML Roadmap
  
Released
Development

No branches or pull requests

2 participants