Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dollar sign re-renders whole template #449

Closed
okeegan opened this issue Nov 25, 2016 · 3 comments
Closed

Dollar sign re-renders whole template #449

okeegan opened this issue Nov 25, 2016 · 3 comments

Comments

@okeegan
Copy link
Contributor

okeegan commented Nov 25, 2016

Hi there, I have encountered a bit of an odd issue with the second dollar sign symbol in a template (not the entity - just the character itself); it inserts the whole template at the second dollar sign's location. When the second dollar sign is removed or replaced by an entity, everything renders normally.

I have managed to replicate the behaviour it the 'try it live' gadget here.

Here is the code itself:

<mjml>
  <mj-body>
    <mj-container>
      <mj-section>
        <mj-column>
          <mj-text padding-bottom="40px" align="center">Hello I am a title</mj-text>
          <mj-section align="center">
            <mj-column>
              <mj-text align="center" color="#999999">1. Make email template</mj-text>
              <mj-image src="../assets/horiz-step-1.png" alt="Step 1" width="48px" align="center" padding="20px 0" />
              <mj-text align="center" color="#999999">Frogs beans $450 bacon pepper pancakes</mj-text>
            </mj-column>
            <mj-column>
              <mj-text align="center" color="#999999">2. ???</mj-text>
              <mj-image src="../assets/horiz-step-2.png" alt="Step 2" width="48px" align="center" padding="20px 40px" />
              <mj-text align="center" color="#999999">Raspberries strawberries mangoes bananas</mj-text>
            </mj-column>
            <mj-column>
              <mj-text align="center" color="#999999">3. Profit</mj-text>
              <mj-image src="../assets/horiz-step-3.png" alt="Step 3" width="48px" align="center" padding="20px 0" />
              <mj-text align="center" color="#999999">Rice noodles bread potatoes $200</mj-text>
            </mj-column>
          </mj-section>
          <mj-section>
            <mj-column>
              <mj-button href="#LINK">
                Find out more
              </mj-button>
            </mj-column>
          </mj-section>
        </mj-column>
      </mj-section>
    </mj-container>
  </mj-body>
</mjml>
@okeegan
Copy link
Contributor Author

okeegan commented Nov 27, 2016

Ah yes, that's definitely the issue!

@iRyusa
Copy link
Member

iRyusa commented Nov 28, 2016

Hi @okeegan ,

I recommend to use &#36; instead of $, I think I can fix this for 3.1

@iRyusa iRyusa closed this as completed in bbd1041 Nov 29, 2016
@iRyusa
Copy link
Member

iRyusa commented Dec 6, 2016

3.1 has been released so $ should now behave correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants