Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current social component should be renamed #67

Closed
Tlapi opened this issue Feb 18, 2016 · 4 comments
Closed

Current social component should be renamed #67

Tlapi opened this issue Feb 18, 2016 · 4 comments
Milestone

Comments

@Tlapi
Copy link

Tlapi commented Feb 18, 2016

Hi,

IMO current "social component" servers for sharing, therefore it should be renamed to "social share".

Then there should be new "social follow" component with links to channels like Twitter, Youtube, Website, Pinterest, Instagram, etc....

Would be happy to contribute with "social follow" component.

@arnaudbreton
Copy link
Contributor

Hey @Tlapi, get your point. Something we can easily do for a future release, even if we have to be careful since it is not backward compatible as it.

For social follow, that's a great idea, more than happy to review your contribution here!

@Tlapi
Copy link
Author

Tlapi commented Mar 8, 2016

Ok, i suggest we could add a attribute to mj-social so that we can set whether it is social follow or social share. If you set it as social follow, url sharer prefixes (like https://www.facebook.com/sharer/sharer.php?u=) will be ignored.

I will make a pull-request for that, feel free to review and comment.

@Tlapi
Copy link
Author

Tlapi commented Mar 8, 2016

Please check this pull request: #126

@iRyusa iRyusa modified the milestone: 1.3 Mar 16, 2016
@iRyusa
Copy link
Member

iRyusa commented Mar 21, 2016

👍 on 1.3 by adding :url on each social network on display

@iRyusa iRyusa closed this as completed Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants