Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create custom social icons with <mj-social-element> #982

Closed
vai0 opened this issue Feb 2, 2018 · 0 comments
Closed

Cannot create custom social icons with <mj-social-element> #982

vai0 opened this issue Feb 2, 2018 · 0 comments
Milestone

Comments

@vai0
Copy link

vai0 commented Feb 2, 2018

Based on the latest docs for mjml 4, when creating custom icons, <mj-social-element> should not be throwing an error for attribute icon.

Observed behavior:

Fails to compile and add custom icon image URL to the social icon <img>

[ { line: 104,
    message: 'Attribute icon-color is illegal',
    tagName: 'mj-social',
    formattedMessage: 'Line 104 of /Users/admin/Projects/eloqua/emails/standard (mj-social) — Attribute icon-color is illegal' },
  { line: 109,
    message: 'Attribute icon is illegal',
    tagName: 'mj-social-element',
    formattedMessage: 'Line 109 of /Users/admin/Projects/eloqua/emails/standard (mj-social-element) — Attribute icon is illegal' },
  { line: 110,
    message: 'Attribute icon is illegal',
    tagName: 'mj-social-element',
    formattedMessage: 'Line 110 of /Users/admin/Projects/eloqua/emails/standard (mj-social-element) — Attribute icon is illegal' },
  { line: 111,
    message: 'Attribute icon is illegal',
    tagName: 'mj-social-element',
    formattedMessage: 'Line 111 of /Users/admin/Projects/eloqua/emails/standard (mj-social-element) — Attribute icon is illegal' } ] 'Line 104 of /Users/admin/Projects/eloqua/emails/standard (mj-social) — Attribute icon-color is illegal' 'Line 109 of /Users/admin/Projects/eloqua/emails/standard (mj-social-element) — Attribute icon is illegal' 'Line 110 of /Users/admin/Projects/eloqua/emails/standard (mj-social-element) — Attribute icon is illegal' 'Line 111 of /Users/admin/Projects/eloqua/emails/standard (mj-social-element) — Attribute icon is illegal'

MJML version:
4.0.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants