Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the type as the identity in storage #39

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Conversation

foreleven
Copy link
Collaborator

No description provided.

@foreleven foreleven requested a review from JounQin August 26, 2019 05:59
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #39 into master will decrease coverage by 0.02%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   93.86%   93.84%   -0.03%     
==========================================
  Files          22       22              
  Lines         277      276       -1     
  Branches       33       33              
==========================================
- Hits          260      259       -1     
  Misses         17       17
Impacted Files Coverage Δ
src/metadata/storage.ts 100% <100%> (ø) ⬆️
src/hooks/useStatedBean.ts 81.81% <100%> (-0.8%) ⬇️
src/core/StatedBeanContainer.ts 94.2% <100%> (ø) ⬆️
src/event/Event.ts 83.33% <88.88%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e1130...3a16a79. Read the comment docs.

@JounQin JounQin merged commit c3c4025 into master Aug 26, 2019
@JounQin JounQin deleted the fix/bean-identity branch August 26, 2019 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants