Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crufty slicing of subvalues #37

Closed
mjordan opened this issue Jul 10, 2019 · 3 comments
Closed

Remove crufty slicing of subvalues #37

mjordan opened this issue Jul 10, 2019 · 3 comments
Assignees

Comments

@mjordan
Copy link
Owner

mjordan commented Jul 10, 2019

Looks like I introduced unnecessary slicing of subvalues in logic that deals with cardinality of field values. Specifically, if the cardinality of a field is -1 (unlimited), I'm slicing on this value, which results in removing the last item in the list.

I will take care of this once issue-20 branch is merged.

@mjordan mjordan self-assigned this Jul 10, 2019
@mjordan mjordan added the bug Something isn't working label Jul 10, 2019
@mjordan
Copy link
Owner Author

mjordan commented Jul 10, 2019

Plus, where we do slice in the update task, we need to slice so that we include any existing field values.

@mjordan mjordan removed the bug Something isn't working label Jul 14, 2019
@mjordan
Copy link
Owner Author

mjordan commented Jul 19, 2019

Part of this issue should be adding a test that field values are added/updated as expected.

mjordan added a commit that referenced this issue Jul 29, 2019
@mjordan
Copy link
Owner Author

mjordan commented Jul 29, 2019

Initial issue fixed, going to create a new one from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant