Skip to content

Commit

Permalink
update cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mjskay committed Mar 2, 2024
1 parent 64abb5d commit 6b55b03
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,7 @@ This release addresses some minor issues introduced by the recent ggplot2 3.5.0

## revdepcheck results

We checked 28 reverse dependencies (26 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
We checked 29 reverse dependencies (27 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 1 new problems
* We saw 0 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems

* fabletools currently fails in one example and two tests due to a change in some internal ggdist data structures (related to colour ramps) that fabletools made use of. The details of those data structures have been changed in this release (causing the error), but this change was done in order to solidify and improve ggdist's public-facing API for colour ramps. As part of that change, the new `ggdist::ramp_colours()` function is now exported that fabletools can use. A PR has been submitted to fabletools to make this change: https://github.com/tidyverts/fabletools/pull/397

0 comments on commit 6b55b03

Please sign in to comment.