Subtitle detection code fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tected as HDDVD Sup files.
|
Thank you for your contribution. Once I am back from vacation I'll give it a try and comment on it or merge it. |
|
I have merged your code. The diff was not against the latest code in master so I fixed the compilation error. For String comparison the equals() method has to be used. |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in file detection code where DVD Sup files are incorrectly detected as HDDVD Sup files. This changes the detection code when a Sup file is opened to see if there is an IFO file that matches the file name of that SUP file to determine if it is a DVD Sup file. This will obviously not fix cases where an IFO file doesn't exist, but it can prevent errors when there is a matching IFO file.