Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FileSystemRegexFinder to correctly find files in subdirectories #4

Merged
merged 1 commit into from
Nov 19, 2013
Merged

Fix FileSystemRegexFinder to correctly find files in subdirectories #4

merged 1 commit into from
Nov 19, 2013

Conversation

anttihirvonen
Copy link
Contributor

This fixes #3.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 02eb1da on anttihirvonen:master into 107b4c6 on mjumbewu:master.

@anttihirvonen
Copy link
Contributor Author

Apparently the build failed on Python 3.3. Will have to investigate...

@mjumbewu mjumbewu merged commit 02eb1da into mjumbewu:master Nov 19, 2013
@mjumbewu
Copy link
Owner

Looks like it's just an ordering issue. When I compare sets instead of lists it works just fine. Order should be disregarded in this case anyway. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makemessages doesn't support subdirectories
3 participants
@anttihirvonen @coveralls @mjumbewu