Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream support #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add stream support #8

wants to merge 2 commits into from

Conversation

randoms
Copy link

@randoms randoms commented Jul 28, 2017

The proxy cannot be used to download large files right now, use http stream to solve the problem.

@mjumbewu
Copy link
Owner

mjumbewu commented Aug 7, 2017

This looks good, but do you know whether StreamingHttpResponse will work for all cases that HttpResponse worked?

@randoms
Copy link
Author

randoms commented Aug 8, 2017

I am not sure. But I reviewed the code of HttpResponse and HttpStreamResponse, it seems to be OK. It's better to have some test case to verify that. I will find some time to do that.

@mjumbewu
Copy link
Owner

mjumbewu commented Aug 8, 2017

That would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants