Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignee list only limited to 101 #95

Closed
max-rh opened this issue Dec 19, 2023 · 15 comments
Closed

Assignee list only limited to 101 #95

max-rh opened this issue Dec 19, 2023 · 15 comments

Comments

@max-rh
Copy link

max-rh commented Dec 19, 2023

Desktop (please complete the following information):

  • OS: MacOS Sonoma
  • Terminal: iTerm
  • Architecture: Apple M2
  • Fjira version: 1.1.8

Describe the bug
After picking the project and within the ticket List, once you click F2 to filter by assignee, the list only shows 101 users and even filtering only filters from those first 101 users.

I am using a self hosted Jira.

Expected behavior
List All Users or somehow to paginate through the pages

@mk-5
Copy link
Owner

mk-5 commented Dec 19, 2023

@max-rh thanks for a report!

There is a higher limit for Jira Cloud - 1000 users. This is why I didn't noticed it before.
I'll improve it in a way that search will query users using API typeahead up to 100 records, and then it will do fuzzy find.

@mk-5
Copy link
Owner

mk-5 commented Dec 23, 2023

could be tested in fjira 1.1.11

@max-rh
Copy link
Author

max-rh commented Dec 24, 2023

I upgraded to 1.1.11, sadly it didnt work, i still can only see 101 users and i can only filter between them.

@mk-5
Copy link
Owner

mk-5 commented Dec 24, 2023

I upgraded to 1.1.11, sadly it didnt work, i still can only see 101 users and i can only filter between them.

mhmm ok, I will have a look after a new year 🙂 - but it's weird because I did a few checks, and it should be fine. For example, when you type m it sends m as a query in assignable typeahead. The result set should be limited to those records. If there is still more then 100 records, and you type another letter like ma - the result set should be limited again. It stop asking API about new results when result set has less records then 100.

I know from different issues that Jira Server, and Jira Cloud could have some differences in an REST API. Maybe query is not supported parameter in Jira Server. I need to investigate it.

Fjira use that API to get users:
https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-user-search/#api-rest-api-2-user-assignable-search-get

@mk-5
Copy link
Owner

mk-5 commented Jan 4, 2024

@max-rh okay, I think I found a reason - https://docs.atlassian.com/software/jira/docs/api/REST/9.10.0/#api/2/user-findAssignableUsers

Jira server has different query parameters. The only supported parameter is username

@mk-5
Copy link
Owner

mk-5 commented Jan 5, 2024

pls check version 1.1.13

@max-rh
Copy link
Author

max-rh commented Jan 9, 2024

Hi @mk-5 , fetching the users works fine now, but once i pick one of the users i get
image

@mk-5
Copy link
Owner

mk-5 commented Jan 11, 2024

@max-rh did you check user in "assign user to ticket" action, or "filter by assignee"?

It needs to be something about Jira Server version. I will try to adapt to that Jira Server API version - but I need some more details

@max-rh
Copy link
Author

max-rh commented Jan 21, 2024

Hey @mk-5 , this was when "filtering by assignee", and my Jira self hosted version is v8.20.11
Hope this helps, any idea where I can get the debug log so that i can be more of a help in this case ?

@mk-5
Copy link
Owner

mk-5 commented Jan 22, 2024

@max-rh I need to introduce some error log file. Unfortunately, the error on the screen is the only visible error at the moment.

The underlying JQL query looks like this:

project=10006 AND assignee=623f8f4b94742a00683fbc2e

Fira use that Jira API in order to fetch the results: /rest/api/2/search. I think that the same Api request should be accessible via such a GET url: https://your-jira-instance/rest/api/2/search?jql={jql}&maxResults=100&fields=id,key,summary,issuetype,project,reporter,status,assignee&startAt=0

Does user from your query has some "special" characters or something? maybe it's matter of some missing Jql params encoding in fjira.

@mk-5
Copy link
Owner

mk-5 commented Jan 22, 2024

@max-rh okay - I'm able to reproduce that issue :) the fix is on a way

mk-5 added a commit that referenced this issue Jan 22, 2024
mk-5 added a commit that referenced this issue Jan 22, 2024
@max-rh
Copy link
Author

max-rh commented Jan 23, 2024

I can confirm its Fixed !

Thanks Alot @mk-5 , for the fast progress on this. 🥳

@max-rh
Copy link
Author

max-rh commented Jan 23, 2024

this is not the place for this, but is there a way to filter tickets from ALL projects ? that would be so helpful since alot of users work in multiple projects

@max-rh
Copy link
Author

max-rh commented Jan 23, 2024

Actually since this was fixed; i have some suggestions, maybe i can open a discussion or another issue on this

@mk-5
Copy link
Owner

mk-5 commented Jan 23, 2024

@max-rh sure! just open some "feature issue" - with a suggestion.

About the first question - "ALL Projects" - at the moment it should be possible using

fjira jql

or

fjira filters

but those searches work in a bit different way. Just open a suggestion ticket, we will find some good solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants