feat: copy issue key to clipboard #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yvesjans pls check Tests pipeline. (Goreleaser check will fail, don't worry about it) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 79.22% 79.00% -0.22%
==========================================
Files 65 67 +2
Lines 3181 3205 +24
==========================================
+ Hits 2520 2532 +12
- Misses 514 525 +11
- Partials 147 148 +1
☔ View full report in Codecov by Sentry. |
mk-5
reviewed
Nov 6, 2023
| @@ -41,6 +41,7 @@ var ( | |||
| ui.NavItemConfig{Action: ui.ActionComment, Text1: ui.MessageComment, Text2: "[c]", Rune: 'c'}, | |||
| ui.NavItemConfig{Action: ui.ActionAddLabel, Text1: ui.MessageLabel, Text2: "[l]", Rune: 'l'}, | |||
| ui.NavItemConfig{Action: ui.ActionOpen, Text1: ui.MessageOpen, Text2: "[o]", Rune: 'o'}, | |||
| ui.NavItemConfig{Action: ui.ActionCopyIssue, Text1: ui.MessageCopyIssue, Text2: "[y]", Rune: 'y'}, | |||
There was a problem hiding this comment.
mhmm, wouldn't Key: tcell.KeyCtrlC be more intuitive here? 🤔 what do you think?
There was a problem hiding this comment.
Sorry lost sight of this...
I choose y (from Vim yank) as Ctrl+C exits the program...
Happy to take any other suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often have to copy the Jira issue key to the clipboard (create new branch, commit message, ...)
This PR adds this functionality