Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing property, fix call to htmlspecialchars by ensuring the pa… #341

Merged
merged 1 commit into from
May 31, 2023

Conversation

Watkinsong
Copy link

Fix two deprecated warnings:

PHP Deprecated:  Creation of dynamic property XLSXWriter::$tempdir is deprecated in vendor/mk-j/php_xlsxwriter/xlsxwriter.class.php on line 44
PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in vendor/mk-j/php_xlsxwriter/xlsxwriter.class.php on line 760

@ocrow
Copy link

ocrow commented Apr 27, 2023

These two fixes are required for the library to run without warnings under PHP 8.
PHP 7 is now in end of life status.
Requesting this commit be incorporated in a release of the library.

@w263756314
Copy link

support

@mk-j mk-j merged commit f72f0d2 into mk-j:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants