Skip to content

Commit

Permalink
Fixed tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mkalioby committed Nov 3, 2023
1 parent 4a925c8 commit 2090afe
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
15 changes: 10 additions & 5 deletions example/test_app/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,19 @@ def setUp(self) -> None:

def test_disabling_key(self):
key =UserPasskey.objects.filter(user=self.user).latest('id')
self.client.get(reverse('passkeys:toggle') + "?id=" + str(key.id))
self.client.post(reverse('passkeys:toggle') ,data={"id":str(key.id)})
self.assertFalse(UserPasskey.objects.get(id=key.id).enabled)

self.client.get(reverse('passkeys:toggle') + "?id=" + str(key.id))
self.client.post(reverse('passkeys:toggle'), {"id":str(key.id)})
self.assertTrue(UserPasskey.objects.get(id=key.id).enabled)

def test_deleting_key(self):
key = UserPasskey.objects.filter(user=self.user).latest('id')
self.client.get(reverse('passkeys:delKey') + "?id=" + str(key.id))
self.client.post("/auth/login", {"username": "test2", "password": "test2", 'passkeys': ''})
r = self.client.get(reverse('passkeys:delKey') + "?id=" + str(key.id))
self.assertEquals(r.status_code, 405)

self.client.post(reverse('passkeys:delKey'), {"id":str(key.id)})
self.assertEquals(UserPasskey.objects.filter(id=key.id).count(), 0)

def test_wrong_ownership(self):
Expand All @@ -38,9 +42,10 @@ def test_wrong_ownership(self):
key = UserPasskey.objects.filter(user=self.user).latest('id')
self.user = self.user_model.objects.create_user(username="test2", password="test2")
self.client.post("/auth/login", {"username": "test2", "password": "test2", 'passkeys': ''})
r = self.client.get(reverse('passkeys:delKey') + "?id="+str(key.id))

r = self.client.post(reverse('passkeys:delKey'), {"id":str(key.id)})
self.assertEquals(r.status_code, 403)
self.assertEquals(r.content,b"Error: You own this token so you can't delete it")
r = self.client.get(reverse('passkeys:toggle') + "?id=" + str(key.id))
r = self.client.post(reverse('passkeys:toggle'), {"id":str(key.id)})
self.assertEquals(r.status_code, 403)
self.assertEquals(r.content, b"Error: You own this token so you can't toggle it")
3 changes: 2 additions & 1 deletion passkeys/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ def index(request,enroll=False): # noqa
keys = UserPasskey.objects.filter(user=request.user) # pragma: no cover
return render(request,'passkeys/PassKeys.html',{"keys":keys,"enroll":enroll}) # pragma: no cover

@require_http_methods(["POST"])
@login_required
def delKey(request):
if request.method != "POST":
return HttpResponse("Error: You must use a POST request", status=405)
id=request.POST.get("id")
if not id:
return HttpResponse("Error: You are missing a key", status=403)
Expand Down

0 comments on commit 2090afe

Please sign in to comment.