V1.3.0 #15
Closed
V1.3.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| ## v1.3.0 | ||
|
|
||
| * Fix: Change the hardcoded username field, thanks @ashokdelphia | ||
| * Fix: Change Grammer for empty keys cases, thanks @ashokdelphia |
passkeys/templates/PassKeys.html
Outdated
| @@ -80,7 +80,7 @@ | |||
| function deleteKey(id,name) | |||
| { | |||
| $("#modal-title").html("Confirm Delete") | |||
| $("#modal-body").html("Are you sure you want to delete '"+name+"'? you may lose access to your system if this your only 2FA."); | |||
| $("#modal-body").text("Are you sure you want to delete '"+name+"'? you may lose access to your system if this your only 2FA."); | |||
There was a problem hiding this comment.
That sounds strange (not fully sure about context though, I am new to this code).
Shouldn't that be something like "Are you sure you want to delete '"+name+"'? You may lose access to your account if this your only login method."?
- capitalised "You"
- system -> account ("your system" usually is not the same as "this server" / "your account on this server")
- you only lose access if you can't log in otherwise, not only by 2FA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.