Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming improvements #384

Merged

Conversation

KvanTTT
Copy link

@KvanTTT KvanTTT commented Jul 20, 2021

  • Decrease size for output assemblies if reversible renaming mode is used (use compressed prefixes instead of full names for declaring types)
  • Decrease size for output identifiers (drop return type for all members)

@AppVeyorBot
Copy link

Build ConfuserEx 826 failed (commit d41bbaac99 by @KvanTTT)

@KvanTTT KvanTTT force-pushed the ReversibleRenamingImprovements branch from ad189dd to 3974595 Compare July 24, 2021 16:55
@AppVeyorBot
Copy link

Build ConfuserEx 827 completed (commit b567f038e2 by @KvanTTT)

@KvanTTT
Copy link
Author

KvanTTT commented Jul 24, 2021

@wmjordan, please check the version from the current build: https://ci.appveyor.com/project/mkaring/confuserex/builds/40116594/artifacts Output size for reversible mode (not only) should be much smaller.

@wmjordan
Copy link

wmjordan commented Jul 25, 2021

It is amazing. I just used it. I did not observe anything wrong with the output result so far.

The output of my project is working well after this version, and its file size is even smaller than those before #305!

@KvanTTT
Copy link
Author

KvanTTT commented Jul 25, 2021

Yes, this is because of the additional compression of nested classes and parameters.

@AppVeyorBot
Copy link

Build ConfuserEx 828 completed (commit 762893ad33 by @KvanTTT)

Copy link
Owner

@mkaring mkaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong with the indentation of the code file at one spot. Other than that it's good work and will be merged.

return false;
}

public void SetCanRename(object obj, bool val) {
context.Annotations.Set(obj, CanRenameKey, val);
}

public void SetParam(IDnlibDef def, string name, string value) {
public void SetParam(IDnlibDef def, string name, string value) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indention seems to be off here.

@mkaring mkaring added the enhancement New feature or request label Jul 25, 2021
@mkaring mkaring added this to the 1.6 milestone Jul 25, 2021
Use Display name for logging if errors occur
@KvanTTT KvanTTT force-pushed the ReversibleRenamingImprovements branch from 075f2b8 to c8efe56 Compare July 25, 2021 19:00
@AppVeyorBot
Copy link

Build ConfuserEx 831 completed (commit 373a68ba96 by @KvanTTT)

@mkaring mkaring merged commit 7241bb2 into mkaring:master Jul 28, 2021
@KvanTTT KvanTTT deleted the ReversibleRenamingImprovements branch July 28, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants