-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming improvements #384
Renaming improvements #384
Conversation
KvanTTT
commented
Jul 20, 2021
- Decrease size for output assemblies if reversible renaming mode is used (use compressed prefixes instead of full names for declaring types)
- Decrease size for output identifiers (drop return type for all members)
❌ Build ConfuserEx 826 failed (commit d41bbaac99 by @KvanTTT) |
ad189dd
to
3974595
Compare
✅ Build ConfuserEx 827 completed (commit b567f038e2 by @KvanTTT) |
@wmjordan, please check the version from the current build: https://ci.appveyor.com/project/mkaring/confuserex/builds/40116594/artifacts Output size for |
It is amazing. I just used it. I did not observe anything wrong with the output result so far. The output of my project is working well after this version, and its file size is even smaller than those before #305! |
Yes, this is because of the additional compression of nested classes and parameters. |
✅ Build ConfuserEx 828 completed (commit 762893ad33 by @KvanTTT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something went wrong with the indentation of the code file at one spot. Other than that it's good work and will be merged.
Confuser.Renamer/NameService.cs
Outdated
return false; | ||
} | ||
|
||
public void SetCanRename(object obj, bool val) { | ||
context.Annotations.Set(obj, CanRenameKey, val); | ||
} | ||
|
||
public void SetParam(IDnlibDef def, string name, string value) { | ||
public void SetParam(IDnlibDef def, string name, string value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indention seems to be off here.
Use Display name for logging if errors occur
075f2b8
to
c8efe56
Compare
✅ Build ConfuserEx 831 completed (commit 373a68ba96 by @KvanTTT) |