Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed showing content in single line in WP 6.5 #138

Merged
merged 1 commit into from
May 2, 2024

Conversation

chandan-tudu
Copy link
Contributor

In WP 6.5, content is appearing in a single line because <br> is being used in place of \n.

@ellatrix
Copy link

ellatrix commented Apr 6, 2024

I can confirm that this is the right fix. This block should copy the core save function.

@ellatrix
Copy link

ellatrix commented Apr 6, 2024

Ideally, modifications to this block should be done with block filters, or by creating a separate block, so changes to this save function don't need to be copied over all the time. I see that this save function also doesn't escape short codes and embeddable URLs.

@itelmenko
Copy link

Is it for #139 issue?

@itelmenko
Copy link

Please, can you explain (or attach some link) how to build source of this plugin before installing to WP?
I need this fix

@muditbac
Copy link

+1
The changes here works. I build the PR and modified few files from existing release. You can manually install the plugin:
code-syntax-block.zip

@muditbac
Copy link

Highly recommending to merge this branch.

@itelmenko
Copy link

@muditbac Thank you

But how did you build it?

npm install
npm run build

Or something else?

@muditbac
Copy link

Yes, built using npm commands you mentioned. But was not sure on how to generate zip, thus downloaded existing zips and replaced few js files with built files. I know it is hacky, didn't have any other option.

@chandan-tudu
Copy link
Contributor Author

Yes, built using npm commands you mentioned. But was not sure on how to generate zip, thus downloaded existing zips and replaced few js files with built files. I know it is hacky, didn't have any other option.

Read the "justfile"

@danielcharrua
Copy link

danielcharrua commented Apr 25, 2024

@mkaz @westonruter @memuller @jazanne @jeherve @ethanclevenger91

🙏 please include this fix for WP 6.5 users, we need this ASAP.

Thank you.

@mkaz mkaz merged commit 35dbb26 into mkaz:trunk May 2, 2024
@mkaz
Copy link
Owner

mkaz commented May 2, 2024

Merged. Now let's see if I remember how to release 😅

@mkaz
Copy link
Owner

mkaz commented May 2, 2024

Thanks @chandan-tudu, I haven't really been monitoring this repo too much, so I didn't realize it was broken with WP 6.5.
Thanks to @danielcharrua for the email letting me know there was a problem.

All fixed and released in v3.2.0 in WP plugin repo now. (Thank god for automation, release was easy)

@danielcharrua
Copy link

@mkaz thank you! Working now on WP 6.5 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants