Allow using full command paths in headers #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
fm/heading-full-commands
branch
from
875ae3b
to
3706c16
Compare
added 2 commits
February 19, 2021 15:36
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
Description
Allows progressively enhancing rendering to output full command paths, instead of only command names.
The only change is that headers show eg
ddev env lsinstead ofls, and permalinks are eg#ddev-env-lsinstead of#ls.We need the
attr_listextension to be installed, so to bring this change progressively we check for the extension instead of making it a hard-requirement, and keep the old behavior as a fallback (AKA progressive enhancement). This does take a bit of additional code.For cases when
attr_listis already present, I think this behavior is better in any case, so no need for a "force-disable" flag.Preview