Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when the input file has no trailing newline #69

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fix bug when the input file has no trailing newline #69

merged 1 commit into from
Sep 16, 2023

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Sep 15, 2023

ofek
ofek approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Black needs to be updated (we should in fact switch to Ruff for everything)

@oprypin
Copy link
Contributor Author

oprypin commented Sep 15, 2023

@ofek If you don't have objections, one simple way for me to get CI fully working would be to rip out all of the testing setup and replace it with the one that I put into all my projects 😅

Such as
https://github.com/oprypin/mkdocs-literate-nav/blob/9d1efbc37f7bbfc5f788d53d6104af5a1cb27b65/pyproject.toml#L55
https://github.com/oprypin/mkdocs-literate-nav/blob/9d1efbc37f7bbfc5f788d53d6104af5a1cb27b65/.github/workflows/ci.yml#L66

@ofek
Copy link
Collaborator

ofek commented Sep 15, 2023

Sounds good to me! I didn't do the testing setup for this

@oprypin oprypin merged commit a8e51b2 into master Sep 16, 2023
0 of 4 checks passed
@oprypin oprypin deleted the nl branch September 16, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation only renders when there are at least two spaces at the end of .md file
2 participants
@oprypin @ofek