fix: Avoid empty path for index.md redirect target #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deploying version 1.0.2 of the plugin that includes the changes from #19 I noticed that in some situations the build of the site would fail:
I found out that this would happen if:
use_directory_urls: true
index.md
orREADME.md
In this particular situation, after removing the
index.html
from the target path we would obtain an empty string and the call toos.path.relpath
would subsequently fail:https://github.com/datarobot/mkdocs-redirects/blob/b0d564bdc7f2364e4fec0cec6dcf4dc23ca8ea0f/mkdocs_redirects/plugin.py#L56-L60
My fix ensures that in this case the returned string is
./
so thatos.path.relpath
can correctly calculate the relative path.