Improve support for tall nav headers in the mkdocs theme #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a couple csslint errors which need fixed. Also, it might help to provide a screen shot. I could clone your branch locally, but a screenshot would be quicker. |
…docs#716 This adds a new JS function called `applyTopPadding` that updates the top padding of a few elements in the document to account for the height change when the nav header is more than one row.
|
Before: After: Not shown, but works: clicking on entries in the TOC will be scrolled correctly, so the heading isn't cut off anymore. |
jimporter
force-pushed
the
tall-navheader
branch
from
3962902
to
4cbe1a2
Compare
waylan
pushed a commit
to mkdocs/mkdocs-bootswatch
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #716. The original issue there is already fixed on master, but the issue with the nav header at the end of the discussion was still happening.
This adds a new JS function called
applyTopPaddingthat updates the top padding of a few elements in the document to account for the height change when the nav header is more than one row. Sadly, I don't think there's a way to do this without at least a little JS (at least, not yet...).I also fixed the whitespace in
themes/mkdocs/js/base.js, since I accidentally used 2-space indentation in a previous commit...