-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an error when the lang of node prebuild_index is ja
or jp
.
#2178
Conversation
I'm experiencing a problem where I can't search Japanese when using MkDocs. I tested this, but it doesn't improve Japanese search. |
If mkdocs/mkdocs/contrib/search/templates/search/worker.js Lines 36 to 54 in dd903d3
Ideally, this lib would only be loaded if it is needed, so only when In other words, this "fix" is incomplete. |
And I just realized that this PR is 5 months old and I had set the |
I was able to confirm the close of the issue #2333, so I will pay attention to it as well. To solve this, it seems that we need the help of someone who is familiar with the implementation of lunr-languages. |
@m15o 対応ありがとうございます。早速試してみます。 I will try this change immediately. |
@m15o 残念ながらまだコードが不完全で動作していません。
|
@fu-sen And you need to specify the branch name to test the PR:
|
Oh, it looks like my pip command was a bit missing. 😫
Do you know developer tools such as Chrome? You will get a detailed answer using it. |
Also note that even if this is resolved, @waylan and I are aware of the problem in multiple languages and have a debate that cannot be merged. |
This looks good. It just needs a note added to the release notes (under Other Changes and Additions to Version 1.2). |
With the following configuration, node prebuild_index raise an error.
The log is as follows. Formatted for readability:
This PR fixes the issue by adding lunr.TinySegmenter to the prebuild-index dependency.