Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require trailing slash when serving a directory index #2507

Merged
merged 1 commit into from Jul 18, 2021

Conversation

@oprypin
Copy link
Member

@oprypin oprypin commented Jul 17, 2021

Don't require trailing slash when serving a directory index in the livereload/local server.

Instead of showing a 404 error, detect if it's a directory and redirect to a path with a trailing slash added.

Fixes #2456

in the livereload/local server.

Instead of showing a 404 error, detect if it's a directory and redirect to a path with a trailing slash added
@oprypin
Copy link
Member Author

@oprypin oprypin commented Jul 17, 2021

In #2456 (comment) I see that people can perceive this as a blocker even regardless of the fact that it used to work before. So I decided to finally tackle it.

@ultrabug Any objections? Otherwise, merging this tomorrow

@oprypin oprypin merged commit 1b15412 into mkdocs:master Jul 18, 2021
17 checks passed
@oprypin oprypin deleted the sitedir branch Jul 18, 2021
@ultrabug
Copy link
Member

@ultrabug ultrabug commented Jul 20, 2021

Sorry too slow to respond but I agree it's a good move

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants