Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide german locale file for readthedocs theme #2633

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Conversation

Alzi
Copy link
Contributor

@Alzi Alzi commented Oct 23, 2021

I was missing the translation for my own use and thought, I could contribute it as well. :) Hope I did everything right.

@Alzi
Copy link
Contributor Author

Alzi commented Oct 23, 2021

Sorry for the hiccup. Wasn't sure, if the forced commit I did, would also change this request. :/

@oprypin
Copy link
Contributor

oprypin commented Oct 23, 2021

You translated the "readthedocs" theme. Would you also be interested in translating the adjacent "mkdocs" theme.

@Alzi
Copy link
Contributor Author

Alzi commented Oct 23, 2021

Yes, I would like to do that. 🙂 In fact, I already did it and also fixed the problem, that caused the Markdown lint-check to fail (tab instead of spaces). But I have to admit, I'm not sure If I'm supposed to do something else with the pull request now.
I assume, that's it - isn't it? 😃

@oprypin
Copy link
Contributor

oprypin commented Nov 16, 2021

Hi @Alzi,
I'm very sorry that I took so long to reply here.
The pull request is fully good and can be merged. Thanks.
However, in the meantime we merged a big update to the "readthedocs" theme, which added many new strings to translate.
#2585
If you know how to merge in those changes (git pull), you can do it in this pull request and then update the rest of the translations with the same tool you've been using. You can also say that you will do it separately or don't want to do it, then I'll just merge this pull request as is

@Alzi
Copy link
Contributor Author

Alzi commented Nov 16, 2021

Hi @oprypin,
thank you for your message and your response-time is totally fine. :) I updated the translation and would like to mention, that I decided to leave certain words in their English form. (Breadcrumb, Mobile, Footer) I believe, these are fairly well known terms, especially in this context. If I should be more strict, please let me know.

Copy link
Contributor

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@oprypin oprypin merged commit 912978c into mkdocs:master Nov 16, 2021
@ultrabug
Copy link
Member

Thanks and sorry for not stepping in mates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants