Conversation
added 2 commits
November 10, 2023 20:23
The gzip format stores a timestamp inside it, but there's no real point to it being correct. If a site is rebuilt exactly the same twice, the timestamp *metadata* of files will be different sure, but this gzip file was the only one that also had *actual content* that is different each time.
Member
|
Don't you fear that setting a static metadata to a file could introduce unexpected behaviors from third party implementations? On top of my head could be indexing robots that might look at it to update or not a sitemap and indexing but I don't know really, just sharing a thought. |
This comment was marked as abuse.
This comment was marked as abuse.
Member
|
Since sometimes code is faster than words, I'd like to humbly propose another approach with #3468 If you like the idea, I can work on fixing tests and improving the code ofc |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
ultrabug
approved these changes
Dec 4, 2023
Member
ultrabug
left a comment
There was a problem hiding this comment.
Sounds like a nice bargain indeed
|
Are there plans to release a new version which includes this change? Avoid needless changes to the compressed archive in static websites maintained on github would be nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gzip format stores a timestamp inside it, but there's no real point to it being correct.
If a site is rebuilt exactly the same twice, the timestamp metadata of files will be different sure, but this gzip file was the only one that also had actual content that is different each time.
Now instead the date of the gzip file will change only once per day, based on the pages' update date. The sitemap.xml itself also changes once per day already.