Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to active status should recursively move up tree #537

Merged
merged 2 commits into from
May 20, 2015

Conversation

JordanCheney
Copy link
Contributor

Now that the page configuration can include multiple levels of headers and pages setting an item to active should recursively set all items in that tree to active.

@d0ugal d0ugal added the Bug label May 19, 2015
@d0ugal d0ugal added this to the 0.13.0 milestone May 19, 2015
@d0ugal
Copy link
Member

d0ugal commented May 19, 2015

Good spot, that makes sense I think. I'll need to give it a test - ideally we'd have a unittests too

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 7e64e9e on JordanCheney:master into 7180e07 on mkdocs:master.

@d0ugal d0ugal added Update needed and removed Bug labels May 19, 2015
def set_active(self, active=True):
self.active = active
for ancestor in self.ancestors:
ancestor.set_active(active)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an extra newline here.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 6b04586 on JordanCheney:master into 7180e07 on mkdocs:master.

d0ugal added a commit that referenced this pull request May 20, 2015
Change to active status should recursively move up tree
@d0ugal d0ugal merged commit 7d92fff into mkdocs:master May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants