Remove external themes from MkDocs #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The original plan was to do this for 1.0, but I don't see an immediate 1.0 happening, so it is better to start moving things along. |
d0ugal
force-pushed
the
remove-external-themes
branch
from
45ea8ac
to
f794e36
Compare
| @@ -51,7 +51,7 @@ details about these specific themes. | |||
| [MkDocs Bootstrap]: http://mkdocs.github.io/mkdocs-bootstrap/ | |||
| [MkDocs Bootswatch]: http://mkdocs.github.io/mkdocs-bootswatch/ | |||
|
|
|||
| They will be included with MkDocs by default until the 1.0 release. After that | |||
| They will be included with MkDocs by default until a future release. After that | |||
There was a problem hiding this comment.
This is the bad change, it's a slight change in contract. However, given that 1.0 is somewhat mythical and hasn't been defined I think it is okay.
|
I suspect it is okay to do this, and nobody has shouted at me so I'll probably go ahead with it soon. |
d0ugal
force-pushed
the
remove-external-themes
branch
from
f794e36
to
1c1840c
Compare
This change removes the dependency on mkdocs-bootstrap and mkdocs-bootswatch. It also updates all references in the code. The only remaining connection is when a user specifies one of these themes but they are not installed they get slightly helpful error.
d0ugal
force-pushed
the
remove-external-themes
branch
from
1c1840c
to
cc1c9a3
Compare
|
No objections from me. |
d0ugal
added a commit
that referenced
this pull request
Mar 1, 2016
Remove external themes from MkDocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the dependency on mkdocs-bootstrap and mkdocs-bootswatch.
It also updates all references in the code. The only remaining connection is
when a user specifies one of these themes but they are not installed they get
slightly helpful error.