Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rendering of docs, fix some docstrings #7

Closed
wants to merge 1 commit into from

Conversation

pawamoy
Copy link
Member

@pawamoy pawamoy commented Aug 28, 2023

crystal

It uses some mkdocstrings-python insiders features 馃榾 (signature_crossrefs, show_symbol_type_heading and show_symbol_type_toc).

Let me know what you think, just had some fun trying latest mkdocstrings and mkdocstrings-python on your handler docs 馃槃

Also I've identified the problematic docstring sections with this:

% griffe dump -Ldebug -o/dev/null -fdgoogle mkdocstrings_handlers.crystal 2>&1 | grep reasons
DEBUG      mkdocstrings_handlers/crystal/items.py:87: Possible section skipped, reasons: Missing blank line above section
DEBUG      mkdocstrings_handlers/crystal/items.py:89: Possible section skipped, reasons: Missing blank line above section
DEBUG      mkdocstrings_handlers/crystal/items.py:469: Possible section skipped, reasons: Missing blank line above section

(latest Griffe is a bit more strict about section syntax, to avoid false-positives)

@@ -1,4 +1,5 @@
.highlight .gp { /* Generic.Prompt */
.highlight .gp {
/* Generic.Prompt */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this, VSCode auto-formatted it.

@oprypin
Copy link
Member

oprypin commented Aug 30, 2023

Thanks.

Hm but to use insiders that will require some setup, the docs are generated on GitHub without insiders. Also not fully sure if I'm willing to use insiders in the first place

@pawamoy
Copy link
Member Author

pawamoy commented Aug 31, 2023

Yeah I can understand that, it complicates the setup. It was mostly to show you how it looked 馃槃

If you're interested in some of the other changes, edit my comment to check their boxes and I'll keep only those:

  • CSS indentation and external links marker
  • Importing mkdocstrings objects inventory
  • Merging __init__ methods documentation into their parent class' docs
  • Separating signature from the header

Or feel free to close the PR and do these things later, or never 馃榾

@pawamoy
Copy link
Member Author

pawamoy commented Sep 25, 2023

Closing, feel free to pick up any changes here in other commits/PRs 馃檪

@pawamoy pawamoy closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants