Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for MkDocs < 1.4, modernize usages #629

Merged
merged 2 commits into from Oct 26, 2023
Merged

Drop support for MkDocs < 1.4, modernize usages #629

merged 2 commits into from Oct 26, 2023

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Oct 26, 2023

No description provided.

pawamoy
pawamoy approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Just two suggestions for docstrings, to separate the summary from the body when its too long for a single line.

src/mkdocstrings/plugin.py Outdated Show resolved Hide resolved
src/mkdocstrings/plugin.py Outdated Show resolved Hide resolved
@oprypin @pawamoy
Apply suggestions from code review
93c58a3 
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
@pawamoy pawamoy merged commit b61d4d1 into main Oct 26, 2023
3 of 35 checks passed
@oprypin oprypin deleted the drop branch October 28, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oprypin @pawamoy