Fix tests, fix/ignore typing #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, I caused these complications with types 🥲 Each of those ignored places could be better written with a cast, but on the other hand casts kinda suck because they are a runtime operation and don't work with |
|
No worries, CI was failing for other reasons so we both missed the tests failure. Also yeah, I really dislike using |
|
No I mean I made the change to type annotations to be more correct but maybe they should've stayed less correct 😂 |
|
Oh OK, I thought you were speaking about the PR that modernized the tests to use More correct is good! |
oprypin
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.